fix(gax): invalid spec in Connection/Response modules #11342
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
davidjulien
force-pushed
the
fix-invalid-spec-in-gax-http-calls
branch
from
7dab44a
to
054b519
Compare
|
Is something missing to review this PR? |
davidjulien
force-pushed
the
fix-invalid-spec-in-gax-http-calls
branch
from
054b519
to
3356510
Compare
It may trigger invalid dialyzer warnings in apps.
For example, for this piece of code:
```elixir
case Client.indexing_url_notifications_publish( connection, [ {:body, payload} ]) do
{:ok, _} -> :ok
{:error, %{status: 429}} -> {:discard, "Rate-limiting error, please check the quota."}
{:error, :timeout} -> ...
end
```
For the clause `{:error, :timeout}`, dialyzer says `The pattern can never match the type`.
However, it is possible to have `{:error, :timeout}` when Connection fails (because of a timeout).
davidjulien
force-pushed
the
fix-invalid-spec-in-gax-http-calls
branch
from
3356510
to
49105bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Specs in connection.ex and response.ex are not correct. It may trigger invalid dialyzer warnings in apps, which may lead to remove necessary code.
For example, for this piece of code:
For the clause
{:error, :timeout}, dialyzer saysThe pattern can never match the type. However, it is possible to have{:error, :timeout}when Connection fails (because of a timeout).You can verify with this doc: https://hexdocs.pm/tesla/Tesla.html#request/2