Allow poison 5.0.0 in gax #9052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mopp , Any updates on getting this through yet? |
|
@dazuma ping 🙏 🙏 🙏 |
|
Hey please could someone merge this PR? |
metemaad
approved these changes
Dec 6, 2023
|
Hi, @metemaad can you please push this change forward, or point who could do that, I have a project that depends on this library, but is blocking the poison upgrade. 🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Overview
To merge the PR #8251, we need to upgrade the poison in gax in advance.
I just followed the past PR #2888.
I confirmed that the tests passed on my local.
The supported elixir version of the Poison is
~> 1.11. But the supported elixir version of this library is~> 1.6. I think 1.6 is too old and it's time to drop. However, I'm not sure what it does affect. then, I just keep the current implementation.https://github.com/devinus/poison/blob/e5c0867aaf3c9e9cb6da424580dcd8e1a25081d0/mix.exs#L14
@dazuma Could you review and release it?