-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change-Id: Ic3100a36ef484cf6e999e991c00702d7e7294a41 Reviewed-on: https://code-review.googlesource.com/c/google-api-go-client/+/48474 Reviewed-by: kokoro <[email protected]> Reviewed-by: Jean de Klerk <[email protected]> Reviewed-by: Tyler Bui-Palsulich <[email protected]>
- Loading branch information
Showing
281 changed files
with
55,955 additions
and
8,310 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
8a410c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shollyman This commit has broken Go packages dependent on the monitoring API.
For example, these are the errors from the cloudprober build:
surfacers/stackdriver/stackdriver.go:136:16: cannot assign *monitoring.APIService to s.client (type *monitoring.Service) in multiple assignment
surfacers/stackdriver/stackdriver.go:211:26: s.client.Projects undefined (type *monitoring.Service has no field or method Projects)
After this commit, monitoring.New() returns monitoring.APIService instead of monitoring.Service.
It must be an easy fix for cloudprober, but it seems this change has potential of breaking many packages.
8a410c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manugarg we fixed this, but please note in future we don't monitor commit comments - issue tracker is monitored though.