Skip to content

Commit

Permalink
all: regenerate libraries.
Browse files Browse the repository at this point in the history
Change-Id: Ic3100a36ef484cf6e999e991c00702d7e7294a41
Reviewed-on: https://code-review.googlesource.com/c/google-api-go-client/+/48474
Reviewed-by: kokoro <[email protected]>
Reviewed-by: Jean de Klerk <[email protected]>
Reviewed-by: Tyler Bui-Palsulich <[email protected]>
  • Loading branch information
shollyman committed Nov 15, 2019
1 parent 4816819 commit 8a410c2
Show file tree
Hide file tree
Showing 281 changed files with 55,955 additions and 8,310 deletions.
4 changes: 2 additions & 2 deletions abusiveexperiencereport/v1/abusiveexperiencereport-gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions accessapproval/v1beta1/accessapproval-gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 19 additions & 19 deletions accesscontextmanager/v1/accesscontextmanager-gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

2 comments on commit 8a410c2

@manugarg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shollyman This commit has broken Go packages dependent on the monitoring API.

For example, these are the errors from the cloudprober build:
surfacers/stackdriver/stackdriver.go:136:16: cannot assign *monitoring.APIService to s.client (type *monitoring.Service) in multiple assignment
surfacers/stackdriver/stackdriver.go:211:26: s.client.Projects undefined (type *monitoring.Service has no field or method Projects)

After this commit, monitoring.New() returns monitoring.APIService instead of monitoring.Service.

  • func New(client *http.Client) (*Service, error) {
  • func New(client *http.Client) (*APIService, error) {

It must be an easy fix for cloudprober, but it seems this change has potential of breaking many packages.

@broady
Copy link
Contributor

@broady broady commented on 8a410c2 Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manugarg we fixed this, but please note in future we don't monitor commit comments - issue tracker is monitored though.

Please sign in to comment.