Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print debug headers when channel priming fails #1719

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: print debug headers when channel priming fails #1719

wants to merge 3 commits into from

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 20, 2023 •
edited
Loading

TODO: need to update the PR to saving the headers from a successful priming request and then when we get an error w/o trailers we print the last known headers

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 20, 2023
@mutianf mutianf marked this pull request as ready for review January 24, 2024 18:49
@mutianf mutianf requested review from a team as code owners January 24, 2024 18:49
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
igorbernstein2
igorbernstein2 requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rethink this approach. If the connection fails, it most liekly will not have gfe headers. :(

@mutianf mutianf marked this pull request as draft January 25, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutianf @igorbernstein2