Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify sample rows key callable chain #2395

Closed
wants to merge 2 commits into from

Commits on Nov 1, 2024

  1. chore: simplify sample rows key callable chain

    Previously there were 3 chain creators:
    1. createSampleRowKeysBaseCallable
    2. createSampleRowKeysWithRequestCallable
    3. createSampleRowKeysCallable
    
    The primary reason for this is that SampleRowKeysWithRequest was introduced after createSampleRowKeysCallable because it supports authorized views.
    
    This pr simplifies the logic by moving everything into createSampleRowKeysWithRequestCallable and makes createSampleRowKeysCallable be a tiny shim to convert a String tableId into a SampleRowKeysRequest
    
    Change-Id: I8f3f33936211bccc71fb0345c5d87fd9f85b2146
    igorbernstein2 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7d4b753 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Configuration menu
    Copy the full SHA
    0197a03 View commit details
    Browse the repository at this point in the history