This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Kēki ❤️ #35
Open
Kēki ❤️ #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 21, 2020 16:42
ZeWaka
reviewed
Feb 26, 2020
| proc/put_out(var/mob/user as mob) | ||
| if (!src) return | ||
| if (src.litfam) | ||
| src.litfam = 0 |
There was a problem hiding this comment.
Why not use initial() for this and below?
| slicecolor.color = buffer.color | ||
| s.UpdateOverlays(slicecolor,"base") //setting the base overlay of the temporary slice object | ||
| src.ClearSpecificOverlays(thing) | ||
| staticiterator-- |
There was a problem hiding this comment.
I'm unsure as to the purpose of this line, as well as similar usages below
| else | ||
| src.clayer-- | ||
| return | ||
| else if((!(src.litfam)) && (((istype(W,/obj/item/weldingtool) && W:welding)) || (istype(W, /obj/item/device/igniter))) || \ |
| boutput(user, "<span style=\"color:red\">The icing tube isn't full enough to frost the cake!</span>") | ||
| return | ||
| var/frostingtype | ||
| frostingtype = input("Which frosting style would you like?", "Frosting Style", null) as null|anything in frostingstyles |
There was a problem hiding this comment.
It would be nice and much more user-friendly for mass-making of cakes if this selection could be transferred over to the icing tube self attack.
| var/blowout | ||
| var/staticiterator = src.overlays.len | ||
| for(var/i=1,i<=staticiterator,i++) | ||
| if(src.sliced && ("[src.overlay_refs[i]]" == "slice-candle_lit")) |
There was a problem hiding this comment.
could put this inside the other if statement to avoid comparing twice
I missed these in my last PR
Also missed in my big patch, oops
added 9 commits
February 28, 2020 22:59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cakes! cakes! cakes! cakes! cakes! cakes! cakes!
more information and DMIs located on the forum post :D
WARNING:
The item path for icing tubes has been modified, so maps will need to be updated. Icing tubes have been turned into bottles so they can be placed in drink dispensers (as opposed to chem dispensers) and players can drink out of them