PR#78 local merge #126
Merged
PR#78 local merge #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ensure that there are no lines longer than 120 characters * fix imported but not used Union * fix imported but not used AptlyAPIException * fix imported but not used Mirror * removed trailing whitespaces * removed black lines at the end of files
* Incompatible type assignments * Incompatible types for arguments * Incompatible return values
Fixed code style1
I understand that my formatting lacks rhyme or reason, but now this is consistent with the rest of the files.
|
Please see this pull request sent to xaoc7s git repo. I hoped it would be pulled into the original pull request. It corrects mirror.create missing SkipArchitectureCheck and snapshot.create_from_mirror missing its mapping for Description. There are also added unit tests for each to keep coverage at 100% and prevent regression. |
* Fixed Mirror.Create. It didn't make use of filter_with_deps argument. * Organized Mirror.create statements to make them easier to follow. * Created unit tests for Mirror.Create to make sure post request is created correctly. * Renamed misleading test named test_create to test_mirror_from_response and cleaned up the function. (cherry picked from commit 71e19b4)
* Fixed Snapshot.create_from_mirror. Description argument was not being set in the post. * Fixed test_create_from_mirror to check the post request fields to make sure they match expected values. (cherry picked from commit 292be7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.