fix: unexpected uncalled judge in recursive loop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Apr 4, 2019
| if !c.instrs(s.Instrs) && !c.succs(s) { | ||
| return false | ||
| if c.instrs(s.Instrs) || c.succs(s) { | ||
| called = true |
There was a problem hiding this comment.
Why does not return immediately?
There was a problem hiding this comment.
In a defer function, the index of instr won't be 1.
So the loop will be returned before the Instruction was checked.
For an accurate validation, an iteration for "all of" s.Succs values is needed.
There was a problem hiding this comment.
I think this code only checks whether the function was called in any succsesors yet.
Because there is only an assignment which changes value of var called, called = true.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
gostaticanalysis/sqlrows#1
Detail
func (c *calledFrom) succs(b *ssa.BasicBlock) boolignores other than the first BasicBlock in a recursive loop.It causes an unexpected pass through when the function's signature has multiple return values.