Skip to content

Commit

Permalink
fix: remove probably unnecessary unregister
Browse files Browse the repository at this point in the history
When the refresh button is clicked in the navigation drawer, then
startPushService is executed which registers the handler. The
WebSocketService itself is reused, thus isn't created again or
destroyed. From my tests the callback isn't registered twice after the
refresh. Thus, I'd expect the unregister isn't needed at all because
android somehow does this automagically.
  • Loading branch information
jmattheis committed Oct 8, 2023
1 parent 5e67cc8 commit b1be4d7
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import android.app.Notification
import android.app.NotificationManager
import android.app.PendingIntent
import android.app.Service
import android.content.Context
import android.content.Intent
import android.graphics.Color
import android.net.ConnectivityManager
Expand Down Expand Up @@ -80,10 +79,6 @@ internal class WebSocketService : Service() {
override fun onDestroy() {
super.onDestroy()
connection?.close()
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
(getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager)
.unregisterNetworkCallback(networkCallback)
}

Logger.warn("Destroy ${javaClass.simpleName}")
}
Expand Down

0 comments on commit b1be4d7

Please sign in to comment.