feat(siren): add hard check on child receiver type creation

Makefile

@@ -2,7 +2,7 @@ NAME="github.com/goto/siren"
 LAST_COMMIT := $(shell git rev-parse --short HEAD)
 LAST_TAG := "$(shell git rev-list --tags --max-count=1)"
 APP_VERSION := "$(shell git describe --tags ${LAST_TAG})-next"
-PROTON_COMMIT := "6e57afd7de6dc405d17a7f39754fcfe4b9acc497"
+PROTON_COMMIT := "17135ba4eb49148c29263a505edae8eba1271758"
 
 .PHONY: all build test clean dist vet proto install
 

core/notification/service_test.go

@@ -347,7 +347,7 @@ func TestService_BuildFromAlerts(t *testing.T) {
 				t.Errorf("BuildTypeReceiver() error = %v, wantErr %s", err, tt.errString)
 				return
 			}
-			if diff := cmp.Diff(got, tt.want, cmpopts.IgnoreFields(notification.Notification{}, "ID", "UniqueKey")); diff != "" {
+			if diff := cmp.Diff(got, tt.want, cmpopts.IgnoreFields(notification.Notification{}, "ID", "UniqueKey"), cmpopts.SortSlices(func(a, b notification.Notification) bool { return len(a.Labels) < len(b.Labels) })); diff != "" {
 				t.Errorf("BuildFromAlerts() got diff = %v", diff)
 			}
 		})

core/receiver/service.go

@@ -70,6 +70,10 @@ func (s *Service) Create(ctx context.Context, rcv *Receiver) error {
 		return errors.ErrInvalid.WithMsgf("%s", err.Error())
 	}
 
+	if err := s.validateParent(ctx, rcv); err != nil {
+		return err
+	}
+
 	receiverPlugin, err := s.getReceiverPlugin(rcv.Type)
 	if err != nil {
 		return err
@@ -237,3 +241,25 @@ func (s *Service) ExpandParents(ctx context.Context, rcvs []Receiver) ([]Receive
 
 	return rcvs, nil
 }
+
+func (s *Service) validateParent(ctx context.Context, rcv *Receiver) error {
+	if rcv.ParentID == 0 {
+		return nil
+	}
+
+	parentRcv, err := s.repository.Get(ctx, rcv.ParentID)
+	if err != nil {
+		return errors.ErrInvalid.WithMsgf("failed to check parent id %d", rcv.ParentID).WithCausef(err.Error())
+	}
+
+	switch rcv.Type {
+	case TypeSlackChannel:
+		if parentRcv.Type != TypeSlack {
+			return errors.ErrInvalid.WithMsgf("parent of slack_channel type should be slack but found %s", parentRcv.Type)
+		}
+	default:
+		return errors.ErrInvalid.WithMsgf("type %s should not have parent receiver", rcv.Type)
+	}
+
+	return nil
+}

core/receiver/service_test.go

@@ -161,6 +161,36 @@ func TestService_CreateReceiver(t *testing.T) {
 				},
 				Err: errors.New("unsupported receiver type: \"random\""),
 			},
+			{
+				Description: "should return error if type child but wrong parent",
+				Setup: func(rr *mocks.ReceiverRepository, ss *mocks.ConfigResolver) {
+					rr.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), uint64(2)).Return(&receiver.Receiver{Type: receiver.TypeFile}, nil)
+				},
+				Rcv: &receiver.Receiver{
+					ID:   123,
+					Type: receiver.TypeSlackChannel,
+					Configurations: map[string]any{
+						"token": "key",
+					},
+					ParentID: 2,
+				},
+				Err: errors.New("parent of slack_channel type should be slack but found file"),
+			},
+			{
+				Description: "should return error if validateParent return error",
+				Setup: func(rr *mocks.ReceiverRepository, ss *mocks.ConfigResolver) {
+					rr.EXPECT().Get(mock.AnythingOfType("*context.emptyCtx"), uint64(2)).Return(nil, errors.New("some error"))
+				},
+				Rcv: &receiver.Receiver{
+					ID:   123,
+					Type: receiver.TypeSlackChannel,
+					Configurations: map[string]any{
+						"token": "key",
+					},
+					ParentID: 2,
+				},
+				Err: errors.New("failed to check parent id 2"),
+			},
 			{
 				Description: "should return error if PreHookDBTransformConfigs return error",
 				Setup: func(rr *mocks.ReceiverRepository, ss *mocks.ConfigResolver) {

internal/api/v1beta1/receiver.go

@@ -35,6 +35,7 @@ func (s *GRPCServer) ListReceivers(ctx context.Context, req *sirenv1beta1.ListRe
 			Type:           rcv.Type,
 			Configurations: configurations,
 			Labels:         rcv.Labels,
+			ParentId:       rcv.ParentID,
 			CreatedAt:      timestamppb.New(rcv.CreatedAt),
 			UpdatedAt:      timestamppb.New(rcv.UpdatedAt),
 		}
@@ -92,6 +93,7 @@ func (s *GRPCServer) GetReceiver(ctx context.Context, req *sirenv1beta1.GetRecei
 			Labels:         rcv.Labels,
 			Configurations: configuration,
 			Data:           data,
+			ParentId:       rcv.ParentID,
 			CreatedAt:      timestamppb.New(rcv.CreatedAt),
 			UpdatedAt:      timestamppb.New(rcv.UpdatedAt),
 		},

proto/siren.swagger.yaml

@@ -1248,6 +1248,9 @@ definitions:
       updated_at:
         type: string
         format: date-time
+      parent_id:
+        type: string
+        format: uint64
   ReceiverMetadata:
     type: object
     properties: