Skip to content

update tests and fix lint #801

update tests and fix lint

update tests and fix lint #801

Triggered via pull request June 7, 2024 09:13
Status Failure
Total duration 31s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
lint: server/egovernor/component.go#L1
: # github.com/gotomicro/ego/server/egovernor [github.com/gotomicro/ego/server/egovernor.test]
lint: server/egovernor/container.go#L58
assignment mismatch: 1 variable but emetric.NewTCPStatCollector returns 2 values
lint: server/egovernor/container.go#L58
too many arguments in call to emetric.NewTCPStatCollector
lint: core/econf/conf_api_test.go#L4
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint: core/econf/options_test.go#L4
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint: core/econf/file/file_test.go#L4
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint: core/etrace/otel/config.go#L6
SA1019: "go.opentelemetry.io/otel/exporters/jaeger" is deprecated: This module is no longer supported. OpenTelemetry dropped support for Jaeger exporter in July 2023. Jaeger officially accepts and recommends using OTLP. Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp] or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead. (staticcheck)
lint: client/egrpc/interceptor.go#L393
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
lint: core/transport/transport.go#L46
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
lint
issues found
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.