Make identifySamplePoints handle compare

identifySamplePoints works by doing a binary search filling a texture with black (0,0,0,0) and white (1,1,1,1) texels and then sampling it. Any non-zero results means those white pixels were sampled. This doesn't work for comparisons like textureSampleCompare, textureSampleCompareLevel, and textureGatherCompare because the result of those are 0 or 1 so for example, of the comparison is 'always' then all texels will show up as sampled. So, instead, if the builtin being tested is a comparison we convert the call to the corresponding non-comparsion builtin. * textureSampleCompare -> textureSample * textureSampleCompareLevel -> textureSampleLevel * textureGatherCompare -> textureGather This lets us find the sample points as best we can (it assumes those functions sample the same texels). Once we have the sample point we then want to look up the actual values of the texels and print them out. To do this requires reading the texture back from the GPU. We made the texture ourselves so we could maybe theoretically pass the data we sent to the GPU down to identifySamplePoints but it seems good to get the values from the GPU itself so at least they made a round trip through the GPU When, if it's a comparison, we print out the result of each comparison with that texel. Hopefully this will help us identify why these tests don't pass on some devices.
gpuweb · Oct 11, 2024 · 0da532e · 0da532e
1 parent 0f96947
commit 0da532e
Show file tree

Hide file tree

Showing 10 changed files with 352 additions and 102 deletions.
diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureGather.spec.ts
@@ -156,7 +156,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -254,7 +255,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -376,7 +378,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -481,7 +484,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -573,7 +577,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -660,7 +665,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -766,7 +772,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -862,7 +869,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureGatherCompare.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureGatherCompare.spec.ts
@@ -157,7 +157,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -259,7 +260,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -356,7 +358,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -448,7 +451,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureLoad.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureLoad.spec.ts
@@ -155,7 +155,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -237,7 +238,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -320,7 +322,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -416,7 +419,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -498,7 +502,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -674,7 +679,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -752,7 +758,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -828,7 +835,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -912,7 +920,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
@@ -989,7 +998,8 @@ Parameters:
       sampler,
       calls,
       results,
-      stage
+      stage,
+      texture
     );
     t.expectOK(res);
   });
diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureSample.spec.ts
@@ -112,7 +112,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -196,7 +198,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -320,7 +324,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -404,7 +410,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -496,7 +504,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -585,7 +595,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -679,7 +691,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -770,7 +784,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -863,7 +879,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
diff --git a/src/webgpu/shader/execution/expression/call/builtin/textureSampleBias.spec.ts b/src/webgpu/shader/execution/expression/call/builtin/textureSampleBias.spec.ts
@@ -117,7 +117,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -241,7 +243,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -335,7 +339,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });
@@ -432,7 +438,9 @@ Parameters:
       textureType,
       sampler,
       calls,
-      results
+      results,
+      'fragment',
+      texture
     );
     t.expectOK(res);
   });