Fix textureSampleBias #3989
Merged
Fix textureSampleBias #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default gradient mult used [1,1,1] and then set one of them the value that would generate the required mipLevel. But that was ignoring the that if the required mipLevel is less then 0 the 1s left over would generate a mipLevel of 0. For now, make the default [0,0,0]. Another alternative would be to set them all to the desired value that generates the desired mipLevel or, we could set them to something less than the value that generates the desired mip level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default gradient mult used [1,1,1] and then set one of them the value that would generate the required mipLevel. But that was ignoring the that if the required mipLevel is less then 0 the 1s left over would generate a mipLevel of 0.
For now, make the default [0,0,0]. Another alternative would be to set them all to the desired value that generates the desired mipLevel or, we could set them to something less than the value that generates the desired mip level.