Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for validating canvas texture formats in configure() #3997

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

beaufortfrancois
Copy link
Collaborator

The updated test now checks for supported context formats in configure() on content timeline (TypeError) instead of GPU validation error.

Spec PR: gpuweb/gpuweb#4911

image

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) It runs in Chromium patched with https://chromium-review.googlesource.com/c/chromium/src/+/5921467
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@beaufortfrancois beaufortfrancois merged commit ab266c9 into main Oct 11, 2024
1 check passed
@beaufortfrancois beaufortfrancois deleted the configure-format branch October 11, 2024 09:44
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 17, 2024
This CL checks for supported context formats in configure() on content
timeline instead of raising a GPU validation error.

Spec PR: gpuweb/gpuweb#4911
CTS: gpuweb/cts#3997

Change-Id: Ibd0151275a35dc95a42f959f977a9854193fe1bc
Bug: 372837859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5921467
Commit-Queue: Fr <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1369999}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants