Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style issues #7

Closed
wants to merge 1 commit into from
Closed

Fix style issues #7

wants to merge 1 commit into from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Aug 20, 2024 •
edited
Loading

@zakkak
Fix style issues
d3f87a0 
Style issues introduced by
graalvm#4
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 20, 2024
@zakkak
Copy link
Contributor Author

zakkak commented Aug 20, 2024

@simonis or @jerboaa could you please review?

This was referenced Aug 20, 2024
Merged
Merged
jerboaa
jerboaa approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seem like there are truffle failures, but that's a different fix.

@zakkak zakkak requested a review from a team August 21, 2024 08:32
simonis
simonis approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing!

@simonis
Copy link
Contributor

simonis commented Aug 21, 2024

LGTM. Seem like there are truffle failures, but that's a different fix.

This looks like JDK-8316304 which was downported to JDK 21.0.2. It requires oracle/graal#8239 which I thought we already have downported, but apparently not. I'll take a look and do the downport.

See #1 (comment)

@jerboaa
Copy link
Contributor

jerboaa commented Aug 21, 2024

LGTM. Seem like there are truffle failures, but that's a different fix.

This looks like JDK-8316304 which was downported to JDK 21.0.2. It requires oracle/graal#8239 which I thought we already have downported, but apparently not. I'll take a look and do the downport.

Great! Thank you.

@jerboaa jerboaa mentioned this pull request Aug 22, 2024
Merged
@zakkak
Copy link
Contributor Author

zakkak commented Aug 22, 2024

Superseded by #6

@zakkak zakkak closed this Aug 22, 2024
@zakkak zakkak deleted the 2024-08-20-format-issues branch August 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonis simonis simonis approved these changes

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakkak @simonis @jerboaa