Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test requirements and script #3487

Closed
wants to merge 7 commits into from

Conversation

space-nuko
Copy link
Contributor

Closes #3484

@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3487-all-demos

@space-nuko
Copy link
Contributor Author

space-nuko commented Mar 16, 2023

ERROR: Ignored the following versions that require a different python version: 1.0.7 Requires-Python >=3.8
ERROR: Could not find a version that satisfies the requirement contourpy==1.0.7 (from versions: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6)

Should we pin dependencies in test/requirements.in for 3.7 tests? Or maybe remove 3.7 support?

@space-nuko space-nuko force-pushed the windows-tests branch 2 times, most recently from 9fb8b2a to cc570d9 Compare March 17, 2023 18:11
@freddyaboulton
Copy link
Collaborator

Hi @space-nuko ! Thanks for your patience on this.

I agree we should deprecate support for 3.7 but not in this PR. I think what we can do is have separate requirement files for 3.7 and 3.9 until we deprecate 3.7.

@freddyaboulton
Copy link
Collaborator

Actually, the other thing we can do is just remove mlflow as a dependency. If you remove mlflow from requirements.in are you able to generate all the dependencies properly?

@space-nuko
Copy link
Contributor Author

space-nuko commented Mar 17, 2023

The errors are in the CI for Python 3.7, not on my box, since I use 3.10

And correct me if I'm wrong but isn't contourpy a dependency of matplotlib? I don't have errors related to mlflow anymore with the regenerated deps

@freddyaboulton
Copy link
Collaborator

Thanks for the patience @space-nuko !

If you pull in latest main, you will see we have separate dependencies for 3.7 and 3.9. You should now be able to update the 3.9 dependencies without breaking the python 3.7 build.

@abidlabs
Copy link
Member

Hi @space-nuko would you like to update the 3.9 dependencies? (And use that environment for testing locally)

@space-nuko
Copy link
Contributor Author

Just getting around to it actually, thanks for reminding me

@space-nuko
Copy link
Contributor Author

space-nuko commented Mar 23, 2023

It looks like pip-tools will not support transitive dependencies that differ based on operating system/platform

jazzband/pip-tools#563 (comment)

So there might need to be requirements-linux.txt and requirements-windows.txt files in the future

@space-nuko
Copy link
Contributor Author

space-nuko commented Mar 23, 2023

Now fails because of scikit-image/scikit-image#6567

ERROR: Cannot install -r test/requirements.txt (line 181), -r test/requirements.txt (line 328) and scipy==1.10.1 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

The conflict is caused by:
    The user requested scipy==1.10.1
    mlflow 2.2.2 depends on scipy<2
    scikit-image 0.20.0 depends on scipy<1.9.2 and >=1.8; python_version <= "3.9"

@abidlabs
Copy link
Member

Honestly, I'd be fine with getting rid of the test that tests the mlflow integration. It's heavily mocked up so it's not testing much anyways.

Let me open a PR

@space-nuko
Copy link
Contributor Author

space-nuko commented Mar 23, 2023

I don't think it's just mlflow in this case, it's also a scikit-image integration that enables interpretation for gr.Image, and 1.10.1 is the latest scipy, don't understand why pip complains about mlflow because its dependency is satisfied there

@abidlabs
Copy link
Member

Hmm interesting.. okay taking another look at this

@abidlabs
Copy link
Member

Hi @space-nuko, I did some cleanup in a separate PR. Closing this one, I'd appreciate if you can take a look at #3608 and confirms that it works for you

@abidlabs abidlabs closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlflow dependency prevents test requirements from installing on Windows
4 participants