-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test requirements and script #3487
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3487-all-demos |
Should we pin dependencies in |
9fb8b2a
to
cc570d9
Compare
Hi @space-nuko ! Thanks for your patience on this. I agree we should deprecate support for 3.7 but not in this PR. I think what we can do is have separate requirement files for 3.7 and 3.9 until we deprecate 3.7. |
Actually, the other thing we can do is just remove |
The errors are in the CI for Python 3.7, not on my box, since I use 3.10 And correct me if I'm wrong but isn't |
Thanks for the patience @space-nuko ! If you pull in latest main, you will see we have separate dependencies for 3.7 and 3.9. You should now be able to update the 3.9 dependencies without breaking the python 3.7 build. |
Hi @space-nuko would you like to update the 3.9 dependencies? (And use that environment for testing locally) |
Just getting around to it actually, thanks for reminding me |
cc570d9
to
7acacdf
Compare
Output from pip-tools is going to differ if it's run on a different operating system https://pip-tools.readthedocs.io/en/latest/#cross-environment-usage-of-requirements-in-requirements-txt-and-pip-compile
It looks like jazzband/pip-tools#563 (comment) So there might need to be |
Now fails because of scikit-image/scikit-image#6567
|
Honestly, I'd be fine with getting rid of the test that tests the Let me open a PR |
I don't think it's just |
Hmm interesting.. okay taking another look at this |
Hi @space-nuko, I did some cleanup in a separate PR. Closing this one, I'd appreciate if you can take a look at #3608 and confirms that it works for you |
Closes #3484