Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed formatting, spelling, grammar and added seo metadata to all pages #107

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Tanish-Ranjan
Copy link
Contributor

This PR fixes formatting issues, spelling and grammar throughout documentation of the repository and adds seo metadata to all the valid pages effectively completing #100

…mar.

Changes:
- Added seo metadata such as title and description to all the valid pages.
- Fixed broken links.
- Fixed formatting, spelling and grammar.
@Tanish-Ranjan
Copy link
Contributor Author

@Tanish-Ranjan
Copy link
Contributor Author

There is also different closing tag in resources.html:

Is that intentional?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Oct 7, 2024 via email

Changes:
- Added Gradle Build Server to projects readme.
- Added links to all the mentioned projects in projects readme.
- Fixed closing html tag in resources.html
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what happens when Grammarly disables SDK for VS Code :(

@@ -35,10 +35,10 @@ For other cases, other channels might be preferable:

1. If you suspect a security issue in Gradle Build Tool, plugins, its infrastructure, or other components,
please avoid discussing it in public.
Follow the [Gradle Vulnerability Disclosure Policy](../dotgithub/SECURITY/README.md) so that we can triage the issue and protect other Gradle users.
3. If you want to report a confirmed and reproducible issue with Gradle Build Tool or other component,
Follow the [Gradle Vulnerability Disclosure Policy](dotgithub/SECURITY/README.md) so that we can triage the issue and protect other Gradle users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not fixed, I will patch it in my next PR. I think the correct path would be ../../dotgithub/SECURITY/README.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will deploy the checker for the site, I think it is quite stable at the moment

@oleg-nenashev oleg-nenashev merged commit 3d06c55 into gradle:main Oct 8, 2024
1 check passed
@Tanish-Ranjan Tanish-Ranjan deleted the feat/seo-metadata branch October 8, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants