Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for the sharding-by-rule issue and the query hash block bug #12823

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tonychoe
Copy link
Contributor

@tonychoe tonychoe commented Apr 29, 2024

What this PR does / why we need it:

We've found that sharding by rule did not work as expected and figured out the fixes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@tonychoe tonychoe requested a review from a team as a code owner April 29, 2024 19:06
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@tonychoe tonychoe changed the title fix: for the by-rule issue and the query hash block bug fix: for the sharding-by-rule issue and the query hash block bug May 30, 2024
@tonychoe tonychoe changed the title fix: for the sharding-by-rule issue and the query hash block bug Ruler: fix for the sharding-by-rule issue and the query hash block bug May 30, 2024
@tonychoe
Copy link
Contributor Author

@dannykopping would you mind to review? this is about your original code for ruler sharding by rule.

@tonychoe tonychoe changed the title Ruler: fix for the sharding-by-rule issue and the query hash block bug fix: for the sharding-by-rule issue and the query hash block bug Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants