Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extract task computing into a strategy interface #13690

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Extract task computing into a strategy interface #13690

wants to merge 2 commits into from
+896 −567

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Jul 29, 2024 •
edited
Loading

What this PR does / why we need it:

We currently plan tasks by dividing the FP keyspace into a configurable number of equally-sized splits (bloom_split_series_keyspace_by per-tenant config).

We want to be able to implement new strategies and make them configurable. In this PR we extract the current planning to a new strategy pkg and create a factory to make the strategy configurable.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts force-pushed the salvacorts/blooms/planning-tsdb branch from 9613863 to 46e36ca Compare July 29, 2024 11:29
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 29, 2024
@salvacorts salvacorts force-pushed the salvacorts/blooms/planning-tsdb branch 2 times, most recently from 82bda3c to 55c25a4 Compare July 29, 2024 11:44
@salvacorts salvacorts marked this pull request as ready for review July 29, 2024 13:26
@salvacorts salvacorts requested a review from a team as a code owner July 29, 2024 13:26
JStickler
JStickler reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@salvacorts
Extract task computing into a strategy interface
18a33d6 
# Conflicts:
#	pkg/bloombuild/planner/planner_test.go
#	pkg/validation/limits.go
@salvacorts
remove duplicated test after rebase
4c7218b
@salvacorts salvacorts force-pushed the salvacorts/blooms/planning-tsdb branch from 55c25a4 to 4c7218b Compare October 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvacorts @JStickler