-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): Provide default OTLP attribute configuration #14410
Draft
xperimental
wants to merge
14
commits into
grafana:main
Choose a base branch
from
xperimental:otlp-defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openshift-logging tenancy - Extend API for default OTLP label set - Disable autodetection of service.name - Update non-otlp config tests - Simplify OTLP attribute configuration - Remove validator code - Content-assist for runtime config - Add openshift-logging defaults - Only add ignore_defaults to config if needed - Use Loki default OTLP attributes when none are specified
xperimental
force-pushed
the
otlp-defaults
branch
from
October 11, 2024 14:57
3811195
to
3a43315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The main purpose of this PR is to provide a default set of OTLP attributes that will be persisted when using LokiStack in
openshift-logging
tenancy mode.This PR also changes the API for specifying an OTLP attribute configuration in LokiStack to make it easier to use.
Which issue(s) this PR fixes:
LOG-6147
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)