feat(kafka): Add support for SASL auth to Kafka #14487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Oct 15, 2024
| @@ -54,6 +45,9 @@ type Config struct { | |||
| DialTimeout time.Duration `yaml:"dial_timeout"` | |||
| WriteTimeout time.Duration `yaml:"write_timeout"` | |||
|
|
|||
| SASLUsername string `yaml:"sasl_username"` | |||
There was a problem hiding this comment.
Shouldn't you regen the doc ?
There was a problem hiding this comment.
Yes, I have a pre-commit check set up which normally does it for me on git push but I had to skip it this time and rely on CI!
github-actions
bot
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for SASL authentication to Kafka.
Special notes for your reviewer:
kafkapackage importstestkafkawhich importskafkafor the config) so this change ended up being larger than I expected.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.