Add slack DM personal notification policy option

[ravishankar15]

What this PR does

Which issue(s) this PR fixes

Closes #3874

Checklist

• Unit, integration, and e2e (if applicable) tests updated
• Documentation added (or pr:no public docs PR label added if not required)
• CHANGELOG.md updated (or pr:no changelog PR label added if not required)

[Konstantinov-Innokentii]

Not directly related to pr - maybe we want to completely move slack personal notifications to the DMs instead of thread?

[ravishankar15]

@Konstantinov-Innokentii You mean to replace the thread notification of users to DM ? That would reduce the team from having visibility of who is working on the OnCall ticket I believe.

[joeyorlando]

consider updating the documentation around Slack here

[BitKickerBHS]

@Konstantinov-Innokentii You mean to replace the thread notification of users to DM ? That would reduce the team from having visibility of who is working on the OnCall ticket I believe.

The team visibility should still be at the same level. The alert should arrive in the slack channel with a list of invited users correct? But this would just change the individual user notification from a mention that shows up in that users slack thread to a direct message from the Oncall Slack Bot, inviting them to look at the alert in the aforementioned slack channel. Please let me know if I'm not understanding the workflow.
-Thanks

[Konstantinov-Innokentii]

@BitKickerBHS Yep, that's what I meant. However, it's not something team is working on now, just my vision how it should work!

[ravishankar15]

Hi Team, Thanks if that behaviour is kind of like a next upgrade can we merge this PR since we don't have any open questions around this ?

[alyssawada]

LGTM on the documentation front. Will defer to the team for final approval :)

[joeyorlando]

@Konstantinov-Innokentii wdyt?

[Konstantinov-Innokentii]

@joeyorlando I'm not sure if we need to introduce an additional escalation step and have two very simular one, which might affect UX. I prefer to rework the Notify in Slack step to send notifications in DMs instead, just like @BitKickerBHS described. AFAIK there were no product decisions to do that, but I'm advocating for that to reduce the amount of noise.

[ravishankar15]

@BitKickerBHS If the alert arrive in the slack channel with a list of invited users by default they will be notified in threads in slack. As part of this change we wanted to send a DM as well with the message correct ?

@joeyorlando / @Konstantinov-Innokentii I will go ahead and make the changes with a single step. Let me know if I should defer for a different approach.

[BitKickerBHS]

@BitKickerBHS If the alert arrive in the slack channel with a list of invited users by default they will be notified in threads in slack. As part of this change we wanted to send a DM as well with the message correct ?

@joeyorlando / @Konstantinov-Innokentii I will go ahead and make the changes with a single step. Let me know if I should defer for a different approach.

@ravishankar15 imagined the DM message would be instead of the threads notification but if both are necessary that would be fine.

[ravishankar15]

@joeyorlando / @Konstantinov-Innokentii I have made the changes. We are already sending a DM notification when the user is not in the alert channel I added the implementation as an extension to the same.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[BitKickerBHS]

@joeyorlando / @Konstantinov-Innokentii I have made the changes. We are already sending a DM notification when the user is not in the alert channel I added the implementation as an extension to the same.

bumping for visibility.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[BitKickerBHS]

Hello @ravishankar15 just checking to see if this change is still possible.
-Thanks

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!