Add openAPI schema for some internal endpoints #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- /escalation_chain - /escalation_policy - /channel_filter - /user_notification_policy
Ferril
added
pr:no public docs
vadimkerr
reviewed
Sep 19, 2024
Comment on lines
-61
to
-70
| user_id = self.request.query_params.get("user") | ||
| slack_channel_id = self.request.query_params.get("slack_channel") | ||
| channel_filter_id = self.request.query_params.get("channel_filter") |
There was a problem hiding this comment.
I think these are no longer used, can we remove them?
There was a problem hiding this comment.
They have been already removed
There was a problem hiding this comment.
I mean that frontend/mobile app don't seem to use these filters, can we remove them?
There was a problem hiding this comment.
got it, yeah, makes sense 👍
Comment on lines
+351
to
+354
| "/channel_filters", | ||
| "/escalation_chains", | ||
| "/escalation_policies", | ||
| "/notification_policies", |
There was a problem hiding this comment.
might be a good idea to re-generate frontend types and commit them in this PR as well
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
vadimkerr
reviewed
Sep 20, 2024
vadimkerr
had a problem deploying
to
github-pages
GitHub Actions
Failure
vadimkerr
had a problem deploying
to
github-pages
GitHub Actions
Failure
vadimkerr
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
requested changes
Sep 27, 2024
There was a problem hiding this comment.
I think we should revert the pnpm generate-types commit and run that in the packages/grafana-oncall-app directory of grafana/irm instead.
cc: @brojd
This reverts commit 2acad03.
# Conflicts: # engine/apps/api/views/alert_group.py # engine/apps/api/views/escalation_policy.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds openAPI schema for following endpoints:
Which issue(s) this PR closes
Related to https://github.com/grafana/oncall-private/issues/2457
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.