Skip to content

Commit

Permalink
tempo-query: bump to version with separate tls settings
Browse files Browse the repository at this point in the history
Signed-off-by: Benedikt Bongartz <[email protected]>
  • Loading branch information
frzifus committed Oct 11, 2024
1 parent 5238c4c commit d5780d9
Show file tree
Hide file tree
Showing 10 changed files with 33 additions and 17 deletions.
16 changes: 16 additions & 0 deletions .chloggen/tempo-query_server-tls.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. tempostack, tempomonolithic, github action)
component: tempostack

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: bump tempo-query to version with separate tls settings for server and client

# One or more tracking issues related to the change
issues: [1057]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
OPERATOR_VERSION ?= 0.13.0
TEMPO_VERSION ?= 2.5.0
JAEGER_QUERY_VERSION ?= 1.62.0
TEMPO_QUERY_VERSION ?= main-1de25ca
TEMPO_QUERY_VERSION ?= tempo-query-server-tls-1ef95ac
TEMPO_GATEWAY_VERSION ?= main-2024-08-05-11d0d94
TEMPO_GATEWAY_OPA_VERSION ?= main-2024-04-29-914c13f
OAUTH_PROXY_VERSION=4.14
Expand All @@ -12,7 +12,7 @@ MIN_OPENSHIFT_VERSION ?= 4.12

TEMPO_IMAGE ?= docker.io/grafana/tempo:$(TEMPO_VERSION)
JAEGER_QUERY_IMAGE ?= docker.io/jaegertracing/jaeger-query:$(JAEGER_QUERY_VERSION)
TEMPO_QUERY_IMAGE ?= docker.io/grafana/tempo-query:$(TEMPO_QUERY_VERSION)
TEMPO_QUERY_IMAGE ?= ghcr.io/frzifus/tempo-query:$(TEMPO_QUERY_VERSION)
TEMPO_GATEWAY_IMAGE ?= quay.io/observatorium/api:$(TEMPO_GATEWAY_VERSION)
TEMPO_GATEWAY_OPA_IMAGE ?= quay.io/observatorium/opa-openshift:$(TEMPO_GATEWAY_OPA_VERSION)
MUSTGATHER_IMAGE ?= ${IMG_PREFIX}/must-gather:$(OPERATOR_VERSION)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1453,7 +1453,7 @@ spec:
- name: RELATED_IMAGE_JAEGER_QUERY
value: docker.io/jaegertracing/jaeger-query:1.62.0
- name: RELATED_IMAGE_TEMPO_QUERY
value: docker.io/grafana/tempo-query:main-1de25ca
value: ghcr.io/frzifus/tempo-query:tempo-query-server-tls-1ef95ac
- name: RELATED_IMAGE_TEMPO_GATEWAY
value: quay.io/observatorium/api:main-2024-08-05-11d0d94
- name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
Expand Down Expand Up @@ -1602,7 +1602,7 @@ spec:
name: tempo
- image: docker.io/jaegertracing/jaeger-query:1.62.0
name: jaeger-query
- image: docker.io/grafana/tempo-query:main-1de25ca
- image: ghcr.io/frzifus/tempo-query:tempo-query-server-tls-1ef95ac
name: tempo-query
- image: quay.io/observatorium/api:main-2024-08-05-11d0d94
name: tempo-gateway
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1463,7 +1463,7 @@ spec:
- name: RELATED_IMAGE_JAEGER_QUERY
value: docker.io/jaegertracing/jaeger-query:1.62.0
- name: RELATED_IMAGE_TEMPO_QUERY
value: docker.io/grafana/tempo-query:main-1de25ca
value: ghcr.io/frzifus/tempo-query:tempo-query-server-tls-1ef95ac
- name: RELATED_IMAGE_TEMPO_GATEWAY
value: quay.io/observatorium/api:main-2024-08-05-11d0d94
- name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
Expand Down Expand Up @@ -1623,7 +1623,7 @@ spec:
name: tempo
- image: docker.io/jaegertracing/jaeger-query:1.62.0
name: jaeger-query
- image: docker.io/grafana/tempo-query:main-1de25ca
- image: ghcr.io/frzifus/tempo-query:tempo-query-server-tls-1ef95ac
name: tempo-query
- image: quay.io/observatorium/api:main-2024-08-05-11d0d94
name: tempo-gateway
Expand Down
2 changes: 1 addition & 1 deletion config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
- name: RELATED_IMAGE_JAEGER_QUERY
value: docker.io/jaegertracing/jaeger-query:1.62.0
- name: RELATED_IMAGE_TEMPO_QUERY
value: docker.io/grafana/tempo-query:main-1de25ca
value: ghcr.io/frzifus/tempo-query:tempo-query-server-tls-1ef95ac
- name: RELATED_IMAGE_TEMPO_GATEWAY
value: quay.io/observatorium/api:main-2024-08-05-11d0d94
- name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
Expand Down
4 changes: 2 additions & 2 deletions internal/manifests/config/tempo-query.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
address: 127.0.0.1:7777
backend: 127.0.0.1:{{ .HTTPPort }}
address: 0.0.0.0:7777
backend: localhost:{{ .HTTPPort }}
tenant_header_key: {{ .TenantHeader }}
{{- if and .Gates.HTTPEncryption .Gateway }}
tls_enabled: true
Expand Down
4 changes: 2 additions & 2 deletions internal/manifests/monolithic/configmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@ func buildTempoConfig(opts Options) ([]byte, error) {

func buildTempoQueryConfig(jaegerUISpec *v1alpha1.MonolithicJaegerUISpec) ([]byte, error) {
config := tempoQueryConfig{}
config.Address = fmt.Sprintf("127.0.0.1:%d", manifestutils.PortTempoGRPCQuery)
config.Backend = fmt.Sprintf("127.0.0.1:%d", manifestutils.PortHTTPServer)
config.Address = fmt.Sprintf("0.0.0.0:%d", manifestutils.PortTempoGRPCQuery)
config.Backend = fmt.Sprintf("localhost:%d", manifestutils.PortHTTPServer)
config.TenantHeaderKey = manifestutils.TenantHeader
config.ServicesQueryDuration = jaegerUISpec.ServicesQueryDuration.Duration
config.FindTracesConcurrentRequests = jaegerUISpec.FindTracesConcurrentRequests
Expand Down
4 changes: 2 additions & 2 deletions internal/manifests/monolithic/configmap_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ func TestBuildConfigMap(t *testing.T) {

require.NotNil(t, cm.Data["tempo-query.yaml"])
tempoQueryCfg := `
address: 127.0.0.1:7777
backend: 127.0.0.1:3200
address: 0.0.0.0:7777
backend: localhost:3200
tenant_header_key: x-scope-orgid
services_query_duration: 72h0m0s
find_traces_concurrent_requests: 22
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/monolithic-extraconfig/install-tempo-assert.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ spec:
apiVersion: v1
data:
tempo-query.yaml: |
address: 127.0.0.1:7777
backend: 127.0.0.1:3200
address: 0.0.0.0:7777
backend: localhost:3200
tenant_header_key: x-scope-orgid
services_query_duration: 72h0m0s
find_traces_concurrent_requests: 2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,8 @@ data:
usage_report:
reporting_enabled: false
tempo-query.yaml: |
address: 127.0.0.1:7777
backend: 127.0.0.1:3200
address: 0.0.0.0:7777
backend: localhost:3200
tenant_header_key: x-scope-orgid
services_query_duration: 72h0m0s
find_traces_concurrent_requests: 2
Expand Down

0 comments on commit d5780d9

Please sign in to comment.