Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for memberlist bind network configuration #1059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Oct 12, 2024

Fixes #1060

@rubenvp8510 rubenvp8510 added the Do Not Merge This PR is not ready to be merged. label Oct 12, 2024
@rubenvp8510 rubenvp8510 force-pushed the fix_hashring branch 3 times, most recently from c9eee0a to f654fdf Compare October 12, 2024 18:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 21.56863% with 40 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (5238c4c) to head (e42c495).

Files with missing lines Patch % Lines
internal/manifests/memberlist/gossip.go 0.00% 31 Missing ⚠️
internal/manifests/config/build.go 72.72% 3 Missing ⚠️
internal/manifests/compactor/compactor.go 33.33% 1 Missing and 1 partial ⚠️
internal/manifests/distributor/distributor.go 33.33% 1 Missing and 1 partial ⚠️
internal/manifests/ingester/ingester.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   69.14%   68.79%   -0.36%     
==========================================
  Files         110      110              
  Lines        7059     7108      +49     
==========================================
+ Hits         4881     4890       +9     
- Misses       1888     1925      +37     
- Partials      290      293       +3     
Flag Coverage Δ
unittests 68.79% <21.56%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge This PR is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create memberlist ("no private IP address found") on TempoStack
2 participants