tempo-query: separate tls settings for server and client #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
pavolloffay
reviewed
Oct 12, 2024
| @@ -11,6 +11,7 @@ type Config struct { | |||
| Address string `yaml:"address"` | |||
| Backend string `yaml:"backend"` | |||
| TLSEnabled bool `yaml:"tls_enabled" category:"advanced"` | |||
| TLSServerEnabeld bool `yaml:"tls_server_enabled" category:"advanced"` | |||
There was a problem hiding this comment.
can you make some comments for TLSEnabled and TLSServerEnabled ?
frzifus
force-pushed
the
tempo-query/server-tls
branch
from
8e8207e
to
b9dc33f
Compare
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
tempo-query/server-tls
branch
from
b9dc33f
to
b493a12
Compare
|
@frzifus once this is merged please open a PR to backport it to release-v2.6 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR extends tempo-query with the possibility to configure tls for server and client individually.
cc @pavolloffay
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]