Implement terraform Resource methods on resourceMetricsEndpointScrapeJob #1812
Conversation
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
fridgepoet
force-pushed
the
shirley/terraform-resource-methods
branch
from
4fffc5a
to
43a37f0
Compare
fridgepoet
force-pushed
the
shirley/terraform-resource-methods
branch
from
6fde641
to
a70d7b0
Compare
…erraform-resource-methods
| @@ -27,9 +27,6 @@ const ( | |||
|
|
|||
| func NewClient(authToken string, rawURL string, client *http.Client) (*Client, error) { | |||
| parsedURL, err := url.Parse(rawURL) | |||
| if parsedURL.Scheme != "https" { | |||
There was a problem hiding this comment.
Removing this check in order to mock with normal httptest server in acceptance tests.
|
The failing acceptance tests/cloudinstance seems to be from OnCall tests.. https://github.com/grafana/terraform-provider-grafana/actions/runs/11295196530/job/31417373511?pr=1812 |
internal/resources/connections/resource_metrics_endpoint_scrape_job.go
Outdated
Show resolved
Hide resolved
| resp.State.SetAttribute(ctx, path.Root("stack_id"), jobTF.StackID) | ||
| resp.State.SetAttribute(ctx, path.Root("name"), jobTF.Name) | ||
| resp.State.SetAttribute(ctx, path.Root("authentication_method"), jobTF.AuthenticationMethod) | ||
| resp.State.SetAttribute(ctx, path.Root("url"), jobTF.URL) | ||
| resp.State.SetAttribute(ctx, path.Root("scrape_interval_seconds"), jobTF.ScrapeIntervalSeconds) |
There was a problem hiding this comment.
Matt, since we talked about this:
I tested out the scenario where we set the entire object: As you pointed out before, this unintentionally detects drift because we're trying to set an empty username/password.
So we do indeed want to set only the non-sensitive attributes.
| { | ||
| category: "Connections", | ||
| testCheck: func(t *testing.T, filename string) { | ||
| t.Skip() // TODO: Make all examples work |
There was a problem hiding this comment.
This is copied from the other implementations: this is re-running the acceptance tests here in TestAccExamples, but without the declaration of the mock httptest server, these tests fail. I'm not sure what the long-term solution plan is.
The acceptance tests still run and are passing elsewhere.
This implements the methods for a terraform Resource on resourceMetricsEndpointScrapeJob.
Contributes to https://github.com/grafana/cloud-onboarding/issues/7670.