Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Do not fetch tokens for regression tests (during pytest) #1175

Closed
wants to merge 2 commits into from

Conversation

dimakuv
Copy link
Contributor

@dimakuv dimakuv commented Feb 14, 2023

Description of the changes

This was a leftover after #1093

How to test this PR?

CI.


This change is Reviewable

Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)

a discussion (no related file):
How those files are cleaned? Because when you start the app, they're created anyway.


Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @woju)

a discussion (no related file):

Previously, woju (Wojtek Porczyk) wrote…

How those files are cleaned? Because when you start the app, they're created anyway.

Done. There is a problem that Ninja build system doesn't know about these .token files since they are generated by Gramine itself. So had to add an explicit removal, not sure it's a "clean" approach.


a discussion (no related file):
It turns out that our regression-test Python scripts do not use the gramine-sgx wrapper (that generates token if needed), but instead use loader binary directly. So the token files are not generated in that case.

See:

I thought this PR would be simple, but it turns out too complicated. I don't want to spend time on this non-problem anymore. If noone minds, I'll just close it (after some timeout).


@dimakuv
Copy link
Contributor Author

dimakuv commented Feb 15, 2023

Closing, see my other comment. Too complicated.

@dimakuv dimakuv closed this Feb 15, 2023
@dimakuv dimakuv deleted the dimakuv/rm-token-from-pytest branch February 15, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants