Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove warning about "not ready for production" #24

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

aneessahib
Copy link
Contributor

@aneessahib aneessahib commented Oct 19, 2021

Remove warning message https://gramine.readthedocs.io/projects/gsc/en/latest/. All documented security issues from #13 have been addressed.


This change is Reviewable

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @aneessahib)


-- commits, line 2 at r1:
could we expand to Remove warning about "not ready for production"?

Also, you forgot the signoff line.

@aneessahib aneessahib changed the title [Docs] Remove warning [Docs] Remove warning about "not ready for production" Oct 19, 2021
Copy link
Contributor Author

@aneessahib aneessahib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)


-- commits, line 2 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

could we expand to Remove warning about "not ready for production"?

Also, you forgot the signoff line.

Done.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @aneessahib)


-- commits, line 2 at r1:

Previously, aneessahib (Anees Sahib) wrote…

Done.

Now there a dot at the end. We don't put dots at the end of commit-message titles

Copy link
Contributor Author

@aneessahib aneessahib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)


-- commits, line 2 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Now there a dot at the end. We don't put dots at the end of commit-message titles

Done.

dimakuv
dimakuv previously approved these changes Oct 19, 2021
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @aneessahib)


-- commits, line 2 at r3:

about "not ready for production"

This reads weird, because you have "about" and then a literal quote ;) Should be either Remove warning about not being ready for production or Remove "not ready for production" warning.

Copy link
Contributor Author

@aneessahib aneessahib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @mkow)


-- commits, line 2 at r3:

Previously, mkow (Michał Kowalczyk) wrote…
about "not ready for production"

This reads weird, because you have "about" and then a literal quote ;) Should be either Remove warning about not being ready for production or Remove "not ready for production" warning.

ah yes. done.

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @aneessahib)


-- commits, line 2 at r3:

Previously, aneessahib (Anees Sahib) wrote…

ah yes. done.

But without the period please :P

Copy link
Contributor Author

@aneessahib aneessahib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @mkow)


-- commits, line 2 at r3:

Previously, mkow (Michał Kowalczyk) wrote…

But without the period please :P

damn! wonder why the tendency now after quite a few commits. done.

mkow
mkow previously approved these changes Oct 19, 2021
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL)


-- commits, line 2 at r3:

Previously, aneessahib (Anees Sahib) wrote…

damn! wonder why the tendency now after quite a few commits. done.

That reminds me that I should add a check for this in our Reviewable script... ;)

dimakuv
dimakuv previously approved these changes Oct 19, 2021
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit edd80c4 into gramineproject:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants