Added date validation #93
Conversation
|
Cool idea, it looks good on first sight, but I'll do a proper review tonight. Could you fix CI in the meantime? |
src/form.ts
Outdated
| const ctx = await this.conversation.wait(); | ||
| const text = ctx.msg?.text ?? ctx.msg?.caption ?? ""; | ||
| let date = new Date(text); | ||
| if(date === "Invalid Date") { |
There was a problem hiding this comment.
This comparison looks sketchy, though, are you sure that dates work like that?
There was a problem hiding this comment.
Fixed converting date to a string
|
Please revert that fix. You committed a pnpm lock file and reformatted the entire project. If you do not have Deno installed or are unsure how to fix up CI, just drop me a comment and I can fix it up :) |
FreezyEx
force-pushed
the
main
branch
2 times, most recently
from
4f4427d
to
1a5426b
Compare
Installed Deno and reverted. I cannot get format-and-lint to work without modifying the whole file with |
|
I can fix it up later today |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 95.83% 94.60% -1.23%
==========================================
Files 4 4
Lines 840 853 +13
Branches 124 124
==========================================
+ Hits 805 807 +2
- Misses 33 44 +11
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Oh nice, you got it already |
Do I need to do anything else? |
it seems the job is still failing. @KnorpelSenf do you wanna take a look at it? |
Added Date validation to the Form class.
Valid syntax defined here