Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix List input coercion rules #1004

Merged
merged 37 commits into from
Dec 16, 2021
Merged

Fix List input coercion rules #1004

merged 37 commits into from
Dec 16, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 14, 2021 •
edited by tyranron
Loading

Synopsis

For now, [Int]! and [Int!]! can accept Null which contradicts GraphQL Spec.

Solution

Forbid coercing nulls into non-null lists, while allowing for now coercing [1, 2, 3] into [[Int]] (resulting in [[1], [2], [3]]), because this may be an ambiguity error: graphql/graphql-spec#515

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

tyranron and others added 30 commits October 15, 2021 13:05
@tyranron
Change FromInputValue signature and boostrap refactoring
0cb9248
@tyranron
Refactor primitive types, vol.1
584f9ae
@ilslv
Update actix beta
e5481a0
@ilslv
Merge branch 'update-actix-beta' into allow-from-input-value-resolve-…
fdac7c7 
…errors
@ilslv
Merge branch 'master' into allow-from-input-value-resolve-errors
1c0ce20 
# Conflicts:
#	juniper/src/ast.rs
#	juniper_actix/src/lib.rs
@ilslv
Support FromInputValue for arrays
acbdf97
@ilslv
Fix existing tests
7092bf2
@ilslv
Remove more unwraps and panics
111e464
@ilslv
Fix ui codegen tests
555db09
@ilslv
Fix book example and docs
1350245
@ilslv
Merge branch 'master' into allow-from-input-value-resolve-errors
3692c19
@ilslv
Corrections
ea2fe64
@ilslv
CHANGELOG
115c55f
@ilslv
Correction
06e71c3
@ilslv
Forbid __typename on subscription root
53a7c69
@ilslv
CHANGELOG
c1d5631
@tyranron
Minor corrections
64f7f8e
@tyranron
Merge branch 'master' into allow-from-input-value-resolve-errors
ff7c3d7
@tyranron
Corrections
5cc7555
@ilslv
Add tests
3e43886
@ilslv
Merge branch 'master' into forbid_typename_on_subscription_root
0a7b7d7
@ilslv
Tests fixes
efca2c0
@ilslv
Upgrade actix
0112c1a
@ilslv
Use poll_fn()
7006d58
@ilslv
Merge branch 'forbid_typename_on_subscription_root' into allow-from-i…
dd3a43c 
…nput-value-resolve-errors

# Conflicts:
#	juniper/CHANGELOG.md
@ilslv
Add boxed_field_err_fut
f2dbec3
@ilslv
Corrections
91a91a1
@ilslv
Corrections
dd80735
@ilslv
Corrections
00ff1df
@ilslv
Merge branch 'master' into allow-from-input-value-resolve-errors
1f69939 
# Conflicts:
#	integration_tests/juniper_tests/src/issue_372.rs
#	juniper/CHANGELOG.md
#	juniper/src/validation/rules/fields_on_correct_type.rs
#	juniper_actix/src/lib.rs
@ilslv ilslv self-assigned this Dec 14, 2021
@ilslv ilslv added semver::breaking Breaking change in terms of SemVer bug Something isn't working enhancement Improvement of existing features or bugfix labels Dec 14, 2021
@ilslv
Merge branch 'master' into fix-list-coercion
2f9e94e 
# Conflicts:
#	docs/book/content/types/scalars.md
#	integration_tests/async_await/src/main.rs
#	integration_tests/juniper_tests/src/codegen/impl_scalar.rs
#	integration_tests/juniper_tests/src/custom_scalar.rs
#	juniper/CHANGELOG.md
#	juniper/src/executor_tests/introspection/input_object.rs
#	juniper/src/executor_tests/variables.rs
#	juniper/src/macros/helper/mod.rs
#	juniper/src/types/containers.rs
#	juniper/src/validation/input_value.rs
#	juniper/src/validation/test_harness.rs
#	juniper_codegen/src/common/field/arg.rs
#	juniper_codegen/src/common/field/mod.rs
#	juniper_codegen/src/graphql_interface/mod.rs
#	juniper_codegen/src/graphql_object/mod.rs
#	juniper_codegen/src/graphql_subscription/mod.rs
#	juniper_codegen/src/graphql_union/mod.rs
#	juniper_codegen/src/impl_scalar.rs
#	juniper_codegen/src/lib.rs
#	juniper_codegen/src/util/mod.rs
@ilslv
Corrections
506f289
@ilslv
Corrections
45e4221
@ilslv
Copy link
Member Author

ilslv commented Dec 15, 2021 •
edited by tyranron
Loading

FCM

Fix `List` input coercion rules (#1004)

Additionally:
- fix WASM builds after 2.1 version of `bson`

@ilslv
Copy link
Member Author

ilslv commented Dec 15, 2021

wasm builds are broken now because of the bson 2.1.0 version

@ilslv ilslv changed the title Draft: Fix List input coercion rules Fix List input coercion rules Dec 16, 2021
@ilslv ilslv marked this pull request as ready for review December 16, 2021 05:53
@ilslv ilslv requested a review from tyranron December 16, 2021 05:53
tyranron
tyranron approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv 👍

@tyranron tyranron merged commit 265d4c5 into master Dec 16, 2021
@tyranron tyranron deleted the fix-list-coercion branch December 16, 2021 10:36
@tyranron tyranron added this to the 0.16.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
bug Something isn't working enhancement Improvement of existing features or bugfix semver::breaking Breaking change in terms of SemVer
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron