Add missing required versions strings to Teleport Terraform resources #47631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milos-teleport
added
the
no-changelog
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
jimbishopp,
marcoandredinis,
mmcallister,
ptgott and
r0mant
milos-teleport
force-pushed
the
milos-teleport/terraform-resource-versions-in-examples
branch
from
9e4ca30
to
87c899f
Compare
|
🤖 Vercel preview here: https://docs-9jsxuvi9j-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-gu5kmbgl9-goteleport.vercel.app/docs/ver/preview |
milos-teleport
force-pushed
the
milos-teleport/terraform-resource-versions-in-examples
branch
from
87c899f
to
177b4d2
Compare
|
🤖 Vercel preview here: https://docs-6yaiff1rp-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-1iq5mqkb0-goteleport.vercel.app/docs/ver/preview |
tigrato
approved these changes
Oct 16, 2024
|
I am just making some last minute checks to see if this is safe to backport |
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
public-teleport-github-review-bot
bot
removed request for
jimbishopp,
marcoandredinis,
mmcallister,
zmb3,
bernardjkim,
xinding33 and
ptgott
|
protoc-gen-terraform-teleport.yaml is the same between v15/v16/v17 but did not exist in v14 (at least not at that location and/or in that capacity). Backporting only to the safe branches. |
milos-teleport
deleted the
milos-teleport/terraform-resource-versions-in-examples
branch
|
@milos-teleport See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used protoc-gen-terraform-teleport.yaml as the source of truth for these versions.
Once the
.tffiles were updated, I ranmake docsin theintegrations/terraformdirectory to generate docs.