Add machinery to do client-side RDP license caching #47634
Conversation
zmb3
added
backport/branch/v14
no-changelog
Expose a Cgo interface for writing licenses to the agent's process storage.
zmb3
force-pushed
the
zmb3/rdp-license-storage
branch
from
e3c5e8a
to
c992a86
Compare
github-actions
bot
requested review from
codingllama,
probakowski and
rudream
| case len(license) > 0: | ||
| log.InfoContext(context.Background(), "found existing RDP license") |
There was a problem hiding this comment.
what should happen in case of err == nil && len(license) == 0?
There was a problem hiding this comment.
That's not something I've commonly seen in Go code. It's generally safe to assume that a nil error means we're returning valid data.
There was a problem hiding this comment.
So why use additional case here? can we skip it and simply log after switch?
There was a problem hiding this comment.
I'm not sure I follow?
I want to be able to tell from the logs if:
- We know there wasn't an existing license.
- We know there was an existing license.
- We don't know if there was a license or not because we encountered an error.
There was a problem hiding this comment.
Right now the switch is not exhaustive, case where err == nil and len(license) == 0 will log nothing.
So, we either don't care about the length (we assume it's >0 when err==nil) and we can skip the length check (by either returning early in case of errors above and logging happy path outside of switch or changing last case to default) or we do care and should log something different in that case
There was a problem hiding this comment.
Fair enough, we can change the last case to a default case instead.
Expose a Cgo interface for writing licenses to the agent's process storage.