Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SolveAuthenticateChallenge from MFA Ceremony in favor of PromptConstructor #47650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove SolveAuthenticateChallenge from MFA Ceremony in favor of PromptConstructor #47650

wants to merge 1 commit into from
+100 −133

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Oct 17, 2024 •
edited
Loading

Remove the extra (SolveAuthenticateChallenge) field MFA ceremony, as it had few callers and can be replaced by a static prompt constructor instead:

PromptConstructor: func(opts ...mfa.PromptOpt) mfa.Prompt {
	return mfa.PromptFunc(func(ctx context.Context, chal *proto.MFAAuthenticateChallenge (*proto.MFAAuthenticateResponse, error) {
		// solve MFA auth challenge
	})
},

Prerequisite for some SSO MFA changes to follow, which pass some SSO info as prompt opts.

Follow up to #46986

@Joerger Joerger added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 and removed desktop-access labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoandredinis marcoandredinis Awaiting requested review from marcoandredinis

@probakowski probakowski Awaiting requested review from probakowski

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Joerger