Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hardware keys prompts in Connect #47652

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Oct 17, 2024

Closes #30030 #17311 #34415

This is the last PR for a hardware keys support in Connect.

Since yubikey.go now supports custom prompts, we can pass it a one that shows modals in the Electron app.
The prompts are displayed as important modals. The UX of this is not perfect, since if you have to unlock the hardware key during log-in, you will see a dialog on top of other dialog. Earlier I considered integrating these prompts with a login dialog, but that would require some significant changes on the frontend side (if there’s a login in progress the prompt should be a part of the login dialog, otherwise it should be a standalone dialog). Because of the additional complexity, I kept this out of scope.

TODO: Add hardware keys to the test plan.

Best to review commit-by-commit.

How to test it

  1. Build tsh with PIV: PIV=dynamic make build/tsh (same for teleport)
  2. Require a hardware key in your role (I set it to hardware_key_touch_and_pin to have all possible prompts).

changelog: Add support for hardware keys in Teleport Connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yubikey error blocks using Teleport Connect
1 participant