Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(all): add external routing guide #1474

Closed
wants to merge 1 commit into from
Closed

docs(all): add external routing guide #1474

wants to merge 1 commit into from

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

@griest024 griest024 added docs This issue is related to documentation package: external-router @daffodil/external-router labels Apr 27, 2021
@griest024 griest024 requested a review from a team as a code owner April 27, 2021 19:25
@griest024 griest024 mentioned this pull request Apr 27, 2021
Merged
3 tasks
@griest024 griest024 requested a review from a team as a code owner April 27, 2021 21:19
damienwebdev
damienwebdev requested changes Apr 28, 2021
View reviewed changes
libs/external-router/guides/configuration.md
@@ -4,26 +4,87 @@ The External Router exposes configuration via a configuration object passed to t

An array of `DaffTypeRoutePair`s can be passed as the second argument to `forRoot`. They can also be provided through DI using the `daffProvideRouteResolvableByType` function.

## Insertion Strategy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a stackblitz example.

docs/advanced/routing/external-routing.md Show resolved Hide resolved
lderrickable
lderrickable previously approved these changes May 4, 2021
View reviewed changes
@damienwebdev damienwebdev self-assigned this Jan 3, 2024
@damienwebdev
Copy link
Member

Closing in favor of #2907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev requested changes

@lderrickable lderrickable lderrickable left review comments

Assignees

@damienwebdev damienwebdev

Labels
docs This issue is related to documentation package: external-router @daffodil/external-router
Projects
No open projects
Daffodil Docs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@griest024 @damienwebdev @lderrickable