Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): clean up accordion component and update docs #2800

Merged
merged 2 commits into from
May 15, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented May 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Accordion docs are not very well written. Accordion styles need to be updated to be more aligned with other Daffodil components.

Part of: #2767

What is the new behavior?

  1. Deprecate initiallyActive property and change it to initiallyExpanded.
  2. Deprecate daffAccordionItemContent. It's not necessary to have this directive.
  3. Clean up styles
  4. Update header to use <button> element
  5. Add accessibility considerations
  6. Write better docs

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label May 15, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone May 15, 2024
@xelaint xelaint requested a review from a team as a code owner May 15, 2024 00:06
@xelaint xelaint merged commit 66e9639 into develop May 15, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request May 15, 2024
@damienwebdev damienwebdev deleted the accordion-component-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

1 participant