Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(design): update getting started docs #3271

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

docs(design): update getting started docs #3271

wants to merge 3 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #2767

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Oct 15, 2024
@xelaint xelaint requested a review from a team as a code owner October 15, 2024 18:07
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Oct 15, 2024
damienwebdev
damienwebdev requested changes Oct 16, 2024
View reviewed changes
libs/design/guides/getting-started.md Outdated Show resolved Hide resolved
libs/design/guides/getting-started.md
## Next steps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a small challenge here? Something like "try to change the color of the hero" and link to the docs of the hero component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

gracetxgao
gracetxgao previously approved these changes Oct 17, 2024
View reviewed changes
@xelaint xelaint mentioned this pull request Oct 21, 2024
Open
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracetxgao gracetxgao gracetxgao left review comments

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xelaint @damienwebdev @gracetxgao