Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment errors in NNLM #63

Merged
merged 1 commit into from
May 2, 2021
Merged

Fix comment errors in NNLM #63

merged 1 commit into from
May 2, 2021

Conversation

secsilm
Copy link
Contributor

@secsilm secsilm commented Oct 20, 2020

Small mistakes in NNLM:

X = self.C(X) # X : [batch_size, n_step, n_class]
X = X.view(-1, n_step * m) # [batch_size, n_step * n_class]

should be

X = self.C(X) # X : [batch_size, n_step, m]
X = X.view(-1, n_step * m) # [batch_size, n_step * m]

#48

@ZonePG
Copy link

ZonePG commented Jan 24, 2021

@secsilm you are right, I think so too

@graykode graykode merged commit 8ec1aeb into graykode:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants