Change: Make use of GMP command get_resource_names to load tag #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 60.00% 60.04% +0.04%
==========================================
Files 1023 1025 +2
Lines 25145 25201 +56
Branches 7457 7468 +11
==========================================
+ Hits 15087 15133 +46
- Misses 9115 9124 +9
- Partials 943 944 +1 ☔ View full report in Codecov by Sentry. |
resources. Show a loading indicator to the user when data is being loaded.
a-h-abdelsalam
force-pushed
the
improve-loading-tag-resources
branch
from
dc79a2c
to
077b915
Compare
timopollmeier
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make use of the new GMP command get_resource_names to load tag resources.
Show a loading indicator to the user when data is being loaded.
Why
To improve performance, the new GMP command only retrieves the names and ids of tag resources . The loading indicator is added to make it visible to the user that data is being loaded and some wait time is expected.
References
GEA-380
requires greenbone/gvmd#2116 and greenbone/gsad#159