Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user custom setting time date format to main #4154

Merged
merged 9 commits into from
Oct 17, 2024

fix linting

5c332df
Select commit
Loading
Failed to load commit list.
Merged

Add user custom setting time date format to main #4154

fix linting
5c332df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 16, 2024 in 0s

65.60% (-0.06%) compared to f36deb4

View this Pull Request on Codecov

65.60% (-0.06%) compared to f36deb4

Details

Codecov Report

Attention: Patch coverage is 52.75424% with 223 lines in your changes missing coverage. Please review.

Project coverage is 65.60%. Comparing base (f36deb4) to head (5c332df).

Files with missing lines Patch % Lines
src/web/pages/usersettings/generalpart.jsx 0.00% 84 Missing ⚠️
src/web/pages/usersettings/usersettingspage.jsx 0.00% 72 Missing ⚠️
src/web/pages/usersettings/dialog.jsx 0.00% 19 Missing ⚠️
src/web/pages/login/loginpage.jsx 71.87% 9 Missing ⚠️
src/web/utils/userSettingTimeDateFormatters.js 77.50% 9 Missing ⚠️
src/web/components/chart/schedule.jsx 16.66% 5 Missing ⚠️
src/web/pages/notes/detailspage.jsx 20.00% 4 Missing ⚠️
src/web/pages/overrides/detailspage.jsx 20.00% 4 Missing ⚠️
src/gmp/commands/users.js 62.50% 3 Missing ⚠️
src/web/pages/tasks/icons/scheduleicon.jsx 25.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4154      +/-   ##
==========================================
- Coverage   65.66%   65.60%   -0.06%     
==========================================
  Files        1090     1091       +1     
  Lines      102767   103112     +345     
  Branches     6531     6549      +18     
==========================================
+ Hits        67477    67649     +172     
- Misses      35164    35338     +174     
+ Partials      126      125       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov