Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Allow the update of setting variables for time and date formats (backport #179) #183

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 15, 2024

What

Allows the update of setting variables for time and date formats.

Why

To allow updating time and date formats from GSA user settings independently of the language.

References

GEA-430
requires #2283


This is an automatic backport of pull request #179 done by [Mergify](https://mergify.com).

@mergify mergify bot requested review from mattmundell and a team as code owners October 15, 2024 13:33
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 4.54545% with 42 lines in your changes missing coverage. Please review.

Project coverage is 5.72%. Comparing base (15e1b45) to head (7fa6428).
Report is 4 commits behind head on oldstable.

Files with missing lines Patch % Lines
src/gsad_gmp.c 0.00% 42 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           oldstable    #183      +/-   ##
============================================
- Coverage       5.73%   5.72%   -0.01%     
============================================
  Files             17      17              
  Lines           8358    8402      +44     
  Branches         943     951       +8     
============================================
+ Hits             479     481       +2     
- Misses          7870    7912      +42     
  Partials           9       9              
Flag Coverage Δ
unittests 5.72% <4.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-h-abdelsalam a-h-abdelsalam merged commit 6f39231 into oldstable Oct 17, 2024
8 of 10 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the mergify/bp/oldstable/pr-179 branch October 17, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant