Change update_scap_extra return type to void

The return value was always 0, so it can be removed.
greenbone · Jun 5, 2024 · 5306d34 · 5306d34
1 parent 12c5bec
commit 5306d34
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/manage_sql_nvts.c b/src/manage_sql_nvts.c
@@ -2681,7 +2681,7 @@ manage_rebuild (GSList *log_config, const db_conn_info_t *database)
     }
 
   if (ret == 0)
-    ret = update_scap_extra ();
+    update_scap_extra ();
 
   feed_lockfile_unlock (&lockfile);
   manage_option_cleanup ();

diff --git a/src/manage_sql_secinfo.c b/src/manage_sql_secinfo.c
@@ -3980,25 +3980,21 @@ update_scap (gboolean reset_scap_db)
 
 /**
  * @brief Update extra data in the SCAP DB that depends on other feeds.
- *
- * @return 0 success, -1 error.
  */
-int
+void
 update_scap_extra ()
 {
   if (manage_scap_loaded () == 0)
     {
       g_info ("%s: SCAP database missing, skipping extra data update",
               __func__);
-      return 0;
+      return;
     }
 
   g_debug ("%s: update SCAP extra data of VTs", __func__);
   setproctitle ("Syncing SCAP: Updating VT extra data");
 
   update_vt_scap_extra_data ();
-
-  return 0;
 }
 
 /**
@@ -4049,7 +4045,7 @@ rebuild_scap ()
     ret = 2;
 
   if (ret == 0)
-    ret = update_scap_extra ();
+    update_scap_extra ();
 
   if (feed_lockfile_unlock (&lockfile))
     {

diff --git a/src/manage_sql_secinfo.h b/src/manage_sql_secinfo.h
@@ -195,7 +195,7 @@ get_secinfo_commit_size ();
 void
 set_secinfo_commit_size (int);
 
-int
+void
 update_scap_extra ();
 
 #endif /* not _GVMD_MANAGE_SQL_SECINFO_H */