Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to setproctitle #1812

Merged
merged 1 commit into from
May 3, 2022
Merged

switch to setproctitle #1812

merged 1 commit into from
May 3, 2022

Conversation

nichtsfrei
Copy link
Member

@nichtsfrei nichtsfrei commented Apr 28, 2022

Refactor: move from gvm-lib proctitle-set to libbsd setproctitle

To be less dependenct on gvm-libs and have more robust way to set
proctitle this commit switches from gvm-libs proctitle-set to
setproctitle of libbsd.

@nichtsfrei nichtsfrei marked this pull request as ready for review April 28, 2022 13:29
@nichtsfrei nichtsfrei requested a review from a team as a code owner April 28, 2022 13:29
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker image needs an update for the new dependency too

@bjoernricks
Copy link
Contributor

The docker image needs an update for the new dependency too

Ah sorry it has been added in a previous commit already.

@bjoernricks bjoernricks self-requested a review May 3, 2022 11:35
To be less dependenct on gvm-libs and have more robust way to set
proctitle this commit switches from gvm-libs proctitle-set to
setproctitle of libbsd.
@bjoernricks bjoernricks enabled auto-merge May 3, 2022 11:35
@bjoernricks bjoernricks merged commit 7540583 into main May 3, 2022
@bjoernricks bjoernricks deleted the switch-to-setproctitle branch May 3, 2022 11:39
@bjoernricks
Copy link
Contributor

Btw. an update for the container images was actually necessary 72ced60

@cfi-gb
Copy link
Member

cfi-gb commented Sep 4, 2023

It seems this change has introduced a duplicated gvmd: gvmd: in the process tile like e.g.:

gvmd         926  0.0  3.3 429024 273760 ?       SLs  Jun15  18:45 gvmd: gvmd: Wa  --foreground *snip*

which has been solved via #2065 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants