Change: Check trash target references before accessing #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the trash case of GET_TARGETS check that dependent resources like credentials exist before trying to access info about them. This speeds up the GSA trashcan, by skipping some SQL queries that would always return NULL.
Conventional Commits Report
🚀 Conventional commits found. |
mattmundell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the trash case of GET_TARGETS check that dependent resources like credentials exist before trying to access info about them.
Note that this only affects the trash case, because the regular case is already checking resources (eg ssh_credential) before trying to access info (eg credential_name, credential_uuid).
Why
The idea was to speed up the GSA trashcan. The speed seems the same, but we might as well skip the extra queries.
With 1600 trash targets: