Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: GMP doc: add boxes around example XML #2192

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

mattmundell
Copy link
Contributor

What

Add background boxes to the examples in the HTML GMP doc.

This only affects section 7 (Command Details).

The color is chosen to match the Greenbone Community Documentation because the HTML will end up as the Greenbone GMP page.

Why

The GMP doc is very long. Adding these boxes makes it easier to read by showing which parts of the doc are code.

Here's how it looks:
shot

Versus how it looked before:
shot-pre

References

Similar to /pull/2189 for the RNC boxes.

@mattmundell mattmundell requested a review from a team as a code owner May 7, 2024 13:06
Copy link

github-actions bot commented May 7, 2024

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@bjoernricks bjoernricks enabled auto-merge (rebase) May 8, 2024 06:44
@bjoernricks bjoernricks merged commit caabd78 into main May 8, 2024
9 checks passed
@bjoernricks bjoernricks deleted the gmp-doc-eg-box branch May 8, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants