Add: validate source names in CREATE_USER and MODIFY_USER #2205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Validate the auth method names that are passed to
CREATE_USER
andMODIFY_USER
inSOURCES/SOURCE
.Why
Doing the validation is cleaner and safer because it restricts which strings end up in
users.method
in the db.Example
Before this PR you could add a user with a bogus
SOURCE
:and the xxx would be stored in the db:
After the PR:
Similar for MODIFY_USER:
References
Requires greenbone/gvm-libs/pull/819.
Resolves a TODO added in aacc589 in 2013.