Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray ultimate arg from function delete_user #2230

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mattmundell
Copy link
Contributor

What

Remove argument ultimate from function delete_user. This includes removing the redundant processing of attribute ultimate in GMP DELETE_USER.

Why

Cleaner.

I guess this arg was left there in case we wanted to add users to the trashcan. It can be added back if this feature is ever needed.

Quick check

$ o m m '<create_user><name>test8</name><password>test</password></create_user>'
<create_user_response status="201" status_text="OK, resource created" id="21852600-afaf-4053-aeb1-367cb2c3044a" />

$ time o m m '<delete_user user_id="21852600-afaf-4053-aeb1-367cb2c3044a"/>'
<delete_user_response status="200" status_text="OK" />

$ time o m m '<get_users user_id="21852600-afaf-4053-aeb1-367cb2c3044a"/>'
<get_users_response status="404" status_text="Failed to find user '21852600-afaf-4053-aeb1-367cb2c3044a'" />

@mattmundell mattmundell requested a review from a team as a code owner June 18, 2024 19:37
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@a-h-abdelsalam a-h-abdelsalam merged commit a024e78 into main Jun 21, 2024
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the delete-user-ultimate branch June 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants