Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray attribute subtype from GET_AGGREGATES #2233

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mattmundell
Copy link
Contributor

What

Remove the attribute subtype from GMP GET_AGGREGATES.

Why

The attribute is not used.

The attribute has been present since GET_AGGREGATES was added. It looks like the plan was to use the attribute to resolve subtypes of GMP info, for example cpe. However when the info handling was added to GET_AGGREGATES the subtype resolution was covered by type_table (the subtype is passed directly in the type attribute).

References

GET_AGGREGATES initially added in df846f6 in 2014.

info subtype handling added to GET_AGGREGATES shortly after in 0a841c4.

Quick test

$ o m m '<get_aggregates type="cve"/>'
<get_aggregates_response status_text="OK" status="200">
  <aggregate>
    <overall>
      <count>239404</count>

@mattmundell mattmundell requested a review from a team as a code owner June 20, 2024 14:12
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@a-h-abdelsalam a-h-abdelsalam merged commit f2f3ace into main Jun 21, 2024
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the get-aggregates-subtype branch June 21, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants