Remove stray attribute subtype from GET_AGGREGATES #2233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the attribute
subtype
from GMPGET_AGGREGATES
.Why
The attribute is not used.
The attribute has been present since
GET_AGGREGATES
was added. It looks like the plan was to use the attribute to resolve subtypes of GMPinfo
, for examplecpe
. However when theinfo
handling was added toGET_AGGREGATES
the subtype resolution was covered bytype_table
(the subtype is passed directly in thetype
attribute).References
GET_AGGREGATES
initially added in df846f6 in 2014.info
subtype handling added toGET_AGGREGATES
shortly after in 0a841c4.Quick test