Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically typed error handling PoC #1752

Draft
wants to merge 34 commits into
base: rust-only-ssh
Choose a base branch
from
Draft

Statically typed error handling PoC #1752

wants to merge 34 commits into from

Commits on Nov 7, 2024

  1. Rename FunctionErrorKind -> NaslError

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5a8edb3 View commit details
    Browse the repository at this point in the history

  2. Add new variants to NaslError.

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e78273a View commit details
    Browse the repository at this point in the history

  3. Move TrailingPositionalArguments to new variant

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1c5e432 View commit details
    Browse the repository at this point in the history

  4. Improve check_err_matches! ergonomics. 

    More specifically, allow autoconversion into the type of the match pattern, so that one does not need to specify the fully qualified error variant every time.
    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    cfe72fa View commit details
    Browse the repository at this point in the history

  5. Move MissingArguments to ArgumentError

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2e71730 View commit details
    Browse the repository at this point in the history

  6. Move UnexpectedArgument to ArgumentError

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    18c1628 View commit details
    Browse the repository at this point in the history

  7. Move WrongArgument into Argument variant

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e33c0a7 View commit details
    Browse the repository at this point in the history

  8. Move FmtError into StringError

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9c4f10c View commit details
    Browse the repository at this point in the history

  9. Remove IOError from NaslError 

    Move all use cases into custom errors from those builtin modules.
    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c7d9c4b View commit details
    Browse the repository at this point in the history

  10. Move 'authentication' to cryptographic error

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d97fdab View commit details
    Browse the repository at this point in the history

  11. Move GeneralErrorType to InternalError::Storage

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    07f6330 View commit details
    Browse the repository at this point in the history

  12. Remove GeneralErrorType

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    75b9e94 View commit details
    Browse the repository at this point in the history

  13. Move SshError into BuiltinError

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b83bd0e View commit details
    Browse the repository at this point in the history

  14. Remove Dirty in favor of custom errors

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    30094ec View commit details
    Browse the repository at this point in the history

  15. Remove Eq derive on errors

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b35e814 View commit details
    Browse the repository at this point in the history

  16. Remove PartialEq on Error

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    051db68 View commit details
    Browse the repository at this point in the history

  17. Rename back to FunctionErrorKind for the draft PR

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    44a5633 View commit details
    Browse the repository at this point in the history

  18. Add return_value to builtin errors

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    87bf03b View commit details
    Browse the repository at this point in the history

  19. Remove diagnostic variant

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    599cd4c View commit details
    Browse the repository at this point in the history

  20. Remove (&str, &NaslValue) -> FunctionErrorKind impl

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e200214 View commit details
    Browse the repository at this point in the history

  21. Remove From<&str, &str, ContextType> impl

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fea6024 View commit details
    Browse the repository at this point in the history

  22. Remove From<(&str, &str, &NaslValue)> impl

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3dc1cee View commit details
    Browse the repository at this point in the history

  23. Move AttachErrorInfo to utils/error

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2ac8803 View commit details
    Browse the repository at this point in the history

  24. Move FEK (temp)

    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c85da81 View commit details
    Browse the repository at this point in the history

  25. Rename FunctionErrorKind -> FnError. 

    Also rename FunctionError within interpreter to FunctionCallError.
    @Tehforsch
    Tehforsch committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    df373f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Remove StorageError/IOError from InterpreterError

    @Tehforsch
    Tehforsch committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4ea894f View commit details
    Browse the repository at this point in the history

  2. Improve scannerctl error message on Fn errors. 

    Add code location and origin statement to the message.
    @Tehforsch
    Tehforsch committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8f68148 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Implement retry logic

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c0ef012 View commit details
    Browse the repository at this point in the history

  2. Add basic test for retry functionality

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d31835d View commit details
    Browse the repository at this point in the history

  3. Remove clone derive on errors

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1adfac7 View commit details
    Browse the repository at this point in the history

  4. Move PacketForgeryError into RawIpError

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4fa701f View commit details
    Browse the repository at this point in the history

  5. Make BuiltinError return Null by default

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    dedbbea View commit details
    Browse the repository at this point in the history

  6. Re-use WithErrorInfo

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    adbf987 View commit details
    Browse the repository at this point in the history

  7. Change Option<NaslValue> to ReturnBehavior

    @Tehforsch
    Tehforsch committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b161913 View commit details
    Browse the repository at this point in the history